Skip to content

Nebula: Save auth token for 14d #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Nebula: Save auth token for 14d #6864

merged 1 commit into from
Apr 25, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 25, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the maxAge configuration for cookies in the doNebulaLogin and isNebulaLoggedIn functions to use a constant value representing fourteen days instead of a hardcoded value.

Detailed summary

  • Added a constant FOURTEEN_DAYS_IN_SECONDS set to 14 days in seconds.
  • Updated maxAge in doNebulaLogin from 3 days to FOURTEEN_DAYS_IN_SECONDS.
  • Updated maxAge in isNebulaLoggedIn from 3 days to FOURTEEN_DAYS_IN_SECONDS.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7b0a213

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 7:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 7:51pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 7:51pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 7:51pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 7:51pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 19:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 19:32 Inactive
@MananTank MananTank marked this pull request as ready for review April 25, 2025 19:33
@MananTank MananTank requested review from a team as code owners April 25, 2025 19:33
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 25, 2025
This was referenced Apr 25, 2025
Merged
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 25, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank mentioned this pull request Apr 25, 2025
Merged
@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (fee560a) to head (7b0a213).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6864   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 186 ms (+163.06% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 284 ms (+55.19% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 70 ms (+1178.61% 🔺) 183 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 18 ms (+347.24% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 80 ms (+539.08% 🔺) 467 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025 •
edited
Loading

Merge activity

@MananTank MananTank mentioned this pull request Apr 25, 2025
Merged
@MananTank
Nebula: Save auth token for 14d (#6864)
7b0a213 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the session cookie expiration time from 3 days to 14 days by introducing a constant `FOURTEEN_DAYS_IN_SECONDS`. This change is reflected in multiple functions related to user login and session management.

### Detailed summary
- Added constant `FOURTEEN_DAYS_IN_SECONDS` set to `14 * 24 * 60 * 60`.
- Updated `maxAge` for cookies in `doNebulaLogin` to `FOURTEEN_DAYS_IN_SECONDS`.
- Updated `maxAge` for cookies in `isNebulaLoggedIn` to `FOURTEEN_DAYS_IN_SECONDS`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-26-nebula_save_auth_token_for_14d branch from 0ec2fe7 to 7b0a213 Compare April 25, 2025 19:44
Base automatically changed from neb-196 to main April 25, 2025 19:51
@graphite-app graphite-app bot merged commit 7b0a213 into main Apr 25, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 04-26-nebula_save_auth_token_for_14d branch April 25, 2025 19:52
@vercel vercel bot temporarily deployed to Production – login April 25, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 19:53 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 19:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls